Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for minimal node version (currently v20.9.0) #3556

Merged
merged 1 commit into from
Sep 24, 2024
Merged

add tests for minimal node version (currently v20.9.0) #3556

merged 1 commit into from
Sep 24, 2024

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Sep 24, 2024

Beside testing against node version v20.x and v22.x we should also test against the minimal node version, currently v20.9.0.

This is for seeing changes in dependencies which needs higher node version as with the July-24-release, where we wrote node >=20 but shipped an eslint version which required node>=20.9.0.

@khassel khassel requested a review from rejas September 24, 2024 19:18
@sdetweil
Copy link
Collaborator

my scripts are already at 20.9.0

@khassel
Copy link
Collaborator Author

khassel commented Sep 24, 2024

my scripts are already at 20.9.0

yes, no change to last release, but I want to know when we have to change this number ...

@sdetweil
Copy link
Collaborator

i think that is good too.

@rejas rejas merged commit fa6a752 into MagicMirrorOrg:develop Sep 24, 2024
8 checks passed
@khassel khassel deleted the min-node branch September 24, 2024 20:16
@bugsounet bugsounet mentioned this pull request Sep 25, 2024
Merged
rejas pushed a commit that referenced this pull request Sep 25, 2024
@bugsounet
Updated minimal needed node version in package.json (currently v20.…
5ffdf9a 
…9.0) (#3559)

Update of package*.json for minimal node verion requirement (v20.9.0)

 * it's an addition to #3556
* According to changelog v2.28.0: `⚠️ This release needs nodejs version
>= v20.9.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristjanESPERANTO KristjanESPERANTO KristjanESPERANTO approved these changes

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khassel @sdetweil @rejas @KristjanESPERANTO